From 890430c4c08145d0cef295fe80517b5d9222aa3c Mon Sep 17 00:00:00 2001
From: michaelschal <35957947-michaelschal@users.noreply.replit.com>
Date: Tue, 9 Sep 2025 13:31:42 +0000
Subject: [PATCH] Make delivery comments read-only after reconciliation

Disables editing and displays a read-only status for delivery comments once reconciliation is validated, preventing modifications to comments on reconciled deliveries.

Replit-Commit-Author: Agent
Replit-Commit-Session-Id: 9fcf4b21-eb0c-4e53-a567-e2ce4a6ad869
Replit-Commit-Checkpoint-Type: full_checkpoint
Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/1957c339-2757-4d1f-8e92-e9f71a1ce58e/9fcf4b21-eb0c-4e53-a567-e2ce4a6ad869/yiEpJFx
---
 client/src/pages/BLReconciliation.tsx | 44 ++++++++++++++++++---------
 server/routes.ts                      |  5 +++
 2 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/client/src/pages/BLReconciliation.tsx b/client/src/pages/BLReconciliation.tsx
index 1ee3c86..05dcbe3 100644
--- a/client/src/pages/BLReconciliation.tsx
+++ b/client/src/pages/BLReconciliation.tsx
@@ -985,8 +985,8 @@ export default function BLReconciliation() {
                                   variant="outline"
                                   size="sm"
                                   onClick={() => handleOpenCommentModal(delivery)}
-                                  className={`h-8 w-8 p-0 ${delivery.notes ? 'text-blue-600 hover:text-blue-700' : 'text-gray-400 hover:text-gray-600'}`}
-                                  title={delivery.notes ? "Voir/Modifier commentaire" : "Ajouter commentaire"}
+                                  className={`h-8 w-8 p-0 ${delivery.notes ? 'text-blue-600 hover:text-blue-700' : 'text-gray-400 hover:text-gray-600'} ${delivery.reconciled ? 'opacity-70' : ''}`}
+                                  title={delivery.reconciled ? (delivery.notes ? "Voir commentaire (lecture seule)" : "Aucun commentaire") : (delivery.notes ? "Voir/Modifier commentaire" : "Ajouter commentaire")}
                                 >
                                   <MessageSquare className="h-4 w-4" />
                                 </Button>
@@ -1199,8 +1199,8 @@ export default function BLReconciliation() {
                                     delivery.notes 
                                       ? 'text-blue-600 hover:text-blue-700 hover:bg-blue-50' 
                                       : 'text-gray-400 hover:text-gray-600 hover:bg-gray-50'
-                                  }`}
-                                  title={delivery.notes ? "Voir/Modifier commentaire" : "Ajouter commentaire"}
+                                  } ${delivery.reconciled ? 'opacity-70' : ''}`}
+                                  title={delivery.reconciled ? (delivery.notes ? "Voir commentaire (lecture seule)" : "Aucun commentaire") : (delivery.notes ? "Voir/Modifier commentaire" : "Ajouter commentaire")}
                                 >
                                   <MessageSquare className="h-4 w-4" />
                                 </button>
@@ -1389,6 +1389,9 @@ export default function BLReconciliation() {
             <DialogTitle className="flex items-center space-x-2">
               <MessageSquare className="w-5 h-5 text-blue-600" />
               <span>Commentaire de livraison</span>
+              {selectedDeliveryForComment?.reconciled && (
+                <span className="text-sm bg-gray-100 text-gray-600 px-2 py-1 rounded">Lecture seule</span>
+              )}
             </DialogTitle>
           </DialogHeader>
           
@@ -1411,15 +1414,24 @@ export default function BLReconciliation() {
                 <Label htmlFor="comment">Commentaire</Label>
                 <Textarea
                   id="comment"
-                  placeholder="Ajouter un commentaire sur cette livraison..."
+                  placeholder={selectedDeliveryForComment?.reconciled ? "Aucun commentaire" : "Ajouter un commentaire sur cette livraison..."}
                   value={commentText}
                   onChange={(e) => setCommentText(e.target.value)}
                   rows={4}
                   className="min-h-[100px]"
+                  disabled={selectedDeliveryForComment?.reconciled}
+                  readOnly={selectedDeliveryForComment?.reconciled}
                 />
-                <div className="text-xs text-gray-500">
-                  {commentText.length}/500 caractères
-                </div>
+                {!selectedDeliveryForComment?.reconciled && (
+                  <div className="text-xs text-gray-500">
+                    {commentText.length}/500 caractères
+                  </div>
+                )}
+                {selectedDeliveryForComment?.reconciled && (
+                  <div className="text-xs text-orange-600">
+                    Le commentaire ne peut pas être modifié car le rapprochement est validé
+                  </div>
+                )}
               </div>
             </div>
           )}
@@ -1430,14 +1442,16 @@ export default function BLReconciliation() {
               onClick={handleCloseCommentModal}
               disabled={updateNoteMutation.isPending}
             >
-              Annuler
-            </Button>
-            <Button 
-              onClick={handleSaveComment}
-              disabled={updateNoteMutation.isPending || commentText.length > 500}
-            >
-              {updateNoteMutation.isPending ? "Sauvegarde..." : "Enregistrer"}
+              {selectedDeliveryForComment?.reconciled ? "Fermer" : "Annuler"}
             </Button>
+            {!selectedDeliveryForComment?.reconciled && (
+              <Button 
+                onClick={handleSaveComment}
+                disabled={updateNoteMutation.isPending || commentText.length > 500}
+              >
+                {updateNoteMutation.isPending ? "Sauvegarde..." : "Enregistrer"}
+              </Button>
+            )}
           </DialogFooter>
         </DialogContent>
       </Dialog>
diff --git a/server/routes.ts b/server/routes.ts
index 56023ce..21814f9 100644
--- a/server/routes.ts
+++ b/server/routes.ts
@@ -1356,6 +1356,11 @@ export async function registerRoutes(app: Express): Promise<Server> {
 
       const { notes } = req.body;
       
+      // Check if delivery is reconciled (read-only)
+      if (delivery.reconciled) {
+        return res.status(403).json({ message: "Impossible de modifier le commentaire d'une livraison réconciliée" });
+      }
+      
       // Validate notes length
       if (notes && notes.length > 500) {
         return res.status(400).json({ message: "Commentaire trop long (maximum 500 caractères)" });