From a30ff58b7a5c62b25530b117228619c9f971d597 Mon Sep 17 00:00:00 2001
From: michaelschal <35957947-michaelschal@users.noreply.replit.com>
Date: Wed, 3 Sep 2025 09:09:12 +0000
Subject: [PATCH] Adjust access rules for viewing task groups and deliveries

Update route logic to grant 'directeur' role access to all deliveries and remove debug logs from group routes.

Replit-Commit-Author: Agent
Replit-Commit-Session-Id: 28b81ac1-a55f-409c-b6a9-88ad420d8a9a
Replit-Commit-Checkpoint-Type: full_checkpoint
Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/1957c339-2757-4d1f-8e92-e9f71a1ce58e/28b81ac1-a55f-409c-b6a9-88ad420d8a9a/hAUonZr
---
 server/routes.ts | 35 ++---------------------------------
 1 file changed, 2 insertions(+), 33 deletions(-)

diff --git a/server/routes.ts b/server/routes.ts
index 7021768..97e7cd8 100644
--- a/server/routes.ts
+++ b/server/routes.ts
@@ -80,36 +80,12 @@ export async function registerRoutes(app: Express): Promise<Server> {
         return res.status(404).json({ message: "User not found" });
       }
 
-      console.log('🔍 [DEBUG] Groups request:', {
-        userId,
-        userRole: user.role,
-        userGroupsCount: (user as any).userGroups?.length || 0,
-        userGroups: (user as any).userGroups?.map((ug: any) => ({ 
-          groupId: ug.groupId, 
-          groupName: ug.group?.name 
-        })) || []
-      });
-
       // Only admin sees all groups, all other roles (manager, employee, directeur) see only their assigned groups
       if (user.role === 'admin') {
         const groups = await storage.getGroups();
-        console.log('🔍 [DEBUG] Admin - returning all groups:', groups.length);
         res.json(groups);
       } else {
         const userGroups = (user as any).userGroups?.map((ug: any) => ug.group).filter(Boolean) || [];
-        console.log('🔍 [DEBUG] Non-admin - returning filtered groups:', {
-          role: user.role,
-          filteredGroupsCount: userGroups.length,
-          groups: userGroups.map((g: any) => ({ id: g.id, name: g.name }))
-        });
-        
-        // CRITICAL: Si un directeur n'a aucun groupe assigné, retourner un tableau vide
-        // au lieu de tous les groupes
-        if (user.role === 'directeur' && userGroups.length === 0) {
-          console.log('🚨 [CRITICAL] Directeur has no assigned groups - returning empty array');
-          return res.json([]);
-        }
-        
         res.json(userGroups);
       }
     } catch (error) {
@@ -1046,8 +1022,8 @@ export async function registerRoutes(app: Express): Promise<Server> {
         return res.status(403).json({ message: "Insufficient permissions" });
       }
 
-      // Admin has access to all deliveries, others must be in the same group
-      if (user.role !== 'admin') {
+      // Admin and directeur have access to all deliveries, others must be in the same group
+      if (user.role !== 'admin' && user.role !== 'directeur') {
         const userGroupIds = user.userGroups?.map((ug: any) => ug.groupId) || [];
         if (!userGroupIds.includes(delivery.groupId)) {
           console.log('🚫 Access denied - User groups check:', {
@@ -1059,13 +1035,6 @@ export async function registerRoutes(app: Express): Promise<Server> {
           });
           return res.status(403).json({ message: "Access denied to this group" });
         }
-      } else {
-        console.log('✅ Admin access granted for delivery:', {
-          userId: user.id,
-          deliveryId: delivery.id,
-          deliveryGroupId: delivery.groupId,
-          deliverySupplier: delivery.supplier?.name
-        });
       }
 
       const { invoiceReference, blNumber, forceRefresh } = req.body;