Lot 38 : l'outil criteria du mode Code exécuté par la façade

L'outil par lequel le modèle tient les critères d'acceptation de sa tâche
(poser, marquer faits, lister, effacer) partait au Go, qui renvoyait la
liste à la façade comme delta. Il s'exécute maintenant dans le tour de la
façade (chat/crittool.rs, port de toolCriteria) : mêmes messages, ids en
nombre ou en chaîne, vingt critères au plus, `passed` réservé à la passe de
vérification, rangement scellé (chat/crit:<id>), liste poussée à l'écran à
chaque changement par un nouveau champ `deltas` de l'hôte du tour.

Les critères sont rangés sous la discussion du tour (le Go prenait la
discussion active : elles ne diffèrent que si l'utilisateur en change
pendant la génération). see_image reste au Go (préparation de l'image).

Parité : journal de 22 appels tiré du Go (parity_criteria_test.go →
tests/parity_tools/criteria.json), rejoué par tests/tools.rs ; le contrat
du mode Code de tests/lot6.rs est désormais vérifié par la façade seule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016tcGfJWefW5kUGoC2wL8cv
This commit is contained in:
Claude committed 2026-10-16 04:01:03 +00:00
1 parent 1d33ca5a49
commit 76d9dce74a
12 files changed
+1119 -21

No files matched your search

-16
View File
@@ -665,22 +665,6 @@ async fn handle(st: Arc<FakeGo>, req: Request<Incoming>) -> Response<Full<Bytes>
"{name} {}",
v["caps"]["Role"].as_str().unwrap_or_default()
));
if name == "criteria" && v["args"]["action"] == "set" {
let mut chat = st.store.lock().unwrap();
for (k, val) in chat.entry("chat".into()).or_default().iter_mut() {
if !k.starts_with("crit:") {
continue;
}
let mut list: Vec<serde_json::Value> =
serde_json::from_slice(val).unwrap_or_default();
for c in &mut list {
if c["id"] == v["args"]["id"] {
c["status"] = v["args"]["status"].clone();
}
}
*val = serde_json::to_vec(&list).unwrap();
}
}
let by_name = st.tool_results.lock().unwrap().get(name).cloned();
let result = by_name
.or_else(|| st.tool_result.lock().unwrap().clone())
+16 -1
View File
@@ -696,6 +696,7 @@ async fn tour_complet_par_le_go() {
kwargs: Default::default(),
},
queued: Box::new(Vec::new),
deltas: Box::new(|_| {}),
perf_kind: "main",
side_slot: Default::default(),
projsnap: None,
@@ -1089,6 +1090,7 @@ async fn hote_et_sonde_de_gabarit() {
kwargs: Default::default(),
},
queued: Box::new(Vec::new),
deltas: Box::new(|_| {}),
perf_kind: "main",
side_slot: Default::default(),
projsnap: None,
@@ -1259,7 +1261,20 @@ async fn contrat_verifie_par_la_facade() {
Verify each non-passed criterion now (git_diff first), and record every verdict with the criteria tool."
);
assert_eq!(v["tools"][0]["function"]["name"], "criteria");
assert_eq!(*go.tool_log.lock().unwrap(), ["criteria verifier"]);
// L'outil criteria s'exécute dans la façade (lot 38) : rien par le Go ;
// le critère rangé (scellé) passe à « passed », et l'écran reçoit la
// liste.
assert!(go.tool_log.lock().unwrap().is_empty(), "{:?}", go.tool_log);
let stored = go.get("chat", &format!("crit:{id}")).unwrap();
assert_eq!(
stored,
r#"SCELLE:[{"id":1,"text":"les tests passent","status":"passed"}]"#
);
let crit = deltas(&svc, "criteria");
assert_eq!(
crit,
[serde_json::json!([{"id":1,"text":"les tests passent","status":"passed"}])]
);
assert_eq!(
deltas(&svc, "role"),
[serde_json::json!("verifier"), serde_json::json!("")]
@@ -0,0 +1,648 @@
[
{
"name": "liste vide",
"args": {
"action": "list"
},
"out": "[aucun critère]",
"stored": null
},
{
"name": "action absente : liste",
"args": {},
"out": "[aucun critère]",
"stored": null
},
{
"name": "action d'un autre type",
"args": {
"action": 3
},
"out": "[aucun critère]",
"stored": null
},
{
"name": "ajout sans textes",
"args": {
"action": "add"
},
"out": "[erreur] aucun critère fourni (texts)",
"stored": null
},
{
"name": "ajout de textes vides ou d'un autre type",
"args": {
"action": "add",
"texts": [
" ",
4,
null
]
},
"out": "[erreur] aucun critère fourni (texts)",
"stored": null
},
{
"name": "ajout",
"args": {
"action": "add",
"texts": [
" les tests passent ",
"la doc \u003cà jour\u003e \u0026 relue",
""
]
},
"out": "[ok] 2 critère(s) ajouté(s)\n[ ] #1 les tests passent\n[ ] #2 la doc \u003cà jour\u003e \u0026 relue",
"stored": [
{
"id": 1,
"status": "pending",
"text": "les tests passent"
},
{
"id": 2,
"status": "pending",
"text": "la doc \u003cà jour\u003e \u0026 relue"
}
]
},
{
"name": "ajout à la suite",
"args": {
"action": "add",
"texts": [
"pas de régression"
]
},
"out": "[ok] 1 critère(s) ajouté(s)\n[ ] #1 les tests passent\n[ ] #2 la doc \u003cà jour\u003e \u0026 relue\n[ ] #3 pas de régression",
"stored": [
{
"id": 1,
"status": "pending",
"text": "les tests passent"
},
{
"id": 2,
"status": "pending",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "pending",
"text": "pas de régression"
}
]
},
{
"name": "le builder dit fait",
"args": {
"action": "set",
"id": 1,
"status": "completed",
"note": " vérifié à la main "
},
"out": "[ok] critère #1 → completed",
"stored": [
{
"id": 1,
"note": "vérifié à la main",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"status": "pending",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "pending",
"text": "pas de régression"
}
]
},
{
"name": "le builder ne valide pas",
"args": {
"action": "set",
"id": 1,
"status": "passed"
},
"out": "[refusé] Seule la passe de vérification peut marquer un critère passed. Termine ton implémentation ; la vérification suivra.",
"stored": [
{
"id": 1,
"note": "vérifié à la main",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"status": "pending",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "pending",
"text": "pas de régression"
}
]
},
{
"name": "id en chaîne avec #",
"verifier": true,
"args": {
"action": "set",
"id": " #2 ",
"status": "failed",
"note": "lien mort"
},
"out": "[ok] critère #2 → failed",
"stored": [
{
"id": 1,
"note": "vérifié à la main",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "failed",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "pending",
"text": "pas de régression"
}
]
},
{
"name": "id en chaîne illisible",
"verifier": true,
"args": {
"action": "set",
"id": "deux",
"status": "passed"
},
"out": "[erreur] critère #0 inconnu",
"stored": [
{
"id": 1,
"note": "vérifié à la main",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "failed",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "pending",
"text": "pas de régression"
}
]
},
{
"name": "id décimal tronqué",
"verifier": true,
"args": {
"action": "set",
"id": 3.9,
"status": "passed"
},
"out": "[ok] critère #3 → passed",
"stored": [
{
"id": 1,
"note": "vérifié à la main",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "failed",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "note seule",
"args": {
"action": "set",
"id": "+1",
"note": "revu"
},
"out": "[ok] critère #1 → completed",
"stored": [
{
"id": 1,
"note": "revu",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "failed",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "statut libre",
"args": {
"action": "set",
"id": 2,
"status": "bloqué"
},
"out": "[ok] critère #2 → bloqué",
"stored": [
{
"id": 1,
"note": "revu",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "bloqué",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "id inconnu",
"verifier": true,
"args": {
"action": "set",
"id": 9,
"status": "passed"
},
"out": "[erreur] critère #9 inconnu",
"stored": [
{
"id": 1,
"note": "revu",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "bloqué",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "liste",
"args": {
"action": "list"
},
"out": "[~] #1 les tests passent — revu\n[ ] #2 la doc \u003cà jour\u003e \u0026 relue — lien mort\n[✓] #3 pas de régression",
"stored": [
{
"id": 1,
"note": "revu",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "bloqué",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "action inconnue",
"args": {
"action": "reset"
},
"out": "[erreur] action inconnue : reset",
"stored": [
{
"id": 1,
"note": "revu",
"status": "completed",
"text": "les tests passent"
},
{
"id": 2,
"note": "lien mort",
"status": "bloqué",
"text": "la doc \u003cà jour\u003e \u0026 relue"
},
{
"id": 3,
"status": "passed",
"text": "pas de régression"
}
]
},
{
"name": "effacer",
"args": {
"action": "clear"
},
"out": "[ok] critères effacés",
"stored": null
},
{
"name": "effacer à vide",
"args": {
"action": "clear"
},
"out": "[ok] critères effacés",
"stored": null
},
{
"name": "liste pleine",
"put": "[{\"id\":7,\"text\":\"a\",\"status\":\"passed\"},{\"id\":3,\"text\":\"b\",\"status\":\"pending\"}]",
"args": {
"action": "add",
"texts": [
"c",
"d",
"e",
"f",
"g",
"h",
"i",
"j",
"k",
"l",
"m",
"n",
"o",
"p",
"q",
"r",
"s",
"t",
"u",
"v",
"w"
]
},
"out": "[ok] 18 critère(s) ajouté(s)\n[✓] #7 a\n[ ] #3 b\n[ ] #8 c\n[ ] #9 d\n[ ] #10 e\n[ ] #11 f\n[ ] #12 g\n[ ] #13 h\n[ ] #14 i\n[ ] #15 j\n[ ] #16 k\n[ ] #17 l\n[ ] #18 m\n[ ] #19 n\n[ ] #20 o\n[ ] #21 p\n[ ] #22 q\n[ ] #23 r\n[ ] #24 s\n[ ] #25 t",
"stored": [
{
"id": 7,
"status": "passed",
"text": "a"
},
{
"id": 3,
"status": "pending",
"text": "b"
},
{
"id": 8,
"status": "pending",
"text": "c"
},
{
"id": 9,
"status": "pending",
"text": "d"
},
{
"id": 10,
"status": "pending",
"text": "e"
},
{
"id": 11,
"status": "pending",
"text": "f"
},
{
"id": 12,
"status": "pending",
"text": "g"
},
{
"id": 13,
"status": "pending",
"text": "h"
},
{
"id": 14,
"status": "pending",
"text": "i"
},
{
"id": 15,
"status": "pending",
"text": "j"
},
{
"id": 16,
"status": "pending",
"text": "k"
},
{
"id": 17,
"status": "pending",
"text": "l"
},
{
"id": 18,
"status": "pending",
"text": "m"
},
{
"id": 19,
"status": "pending",
"text": "n"
},
{
"id": 20,
"status": "pending",
"text": "o"
},
{
"id": 21,
"status": "pending",
"text": "p"
},
{
"id": 22,
"status": "pending",
"text": "q"
},
{
"id": 23,
"status": "pending",
"text": "r"
},
{
"id": 24,
"status": "pending",
"text": "s"
},
{
"id": 25,
"status": "pending",
"text": "t"
}
]
},
{
"name": "liste déjà pleine",
"args": {
"action": "add",
"texts": [
"x"
]
},
"out": "[erreur] aucun critère fourni (texts)",
"stored": [
{
"id": 7,
"status": "passed",
"text": "a"
},
{
"id": 3,
"status": "pending",
"text": "b"
},
{
"id": 8,
"status": "pending",
"text": "c"
},
{
"id": 9,
"status": "pending",
"text": "d"
},
{
"id": 10,
"status": "pending",
"text": "e"
},
{
"id": 11,
"status": "pending",
"text": "f"
},
{
"id": 12,
"status": "pending",
"text": "g"
},
{
"id": 13,
"status": "pending",
"text": "h"
},
{
"id": 14,
"status": "pending",
"text": "i"
},
{
"id": 15,
"status": "pending",
"text": "j"
},
{
"id": 16,
"status": "pending",
"text": "k"
},
{
"id": 17,
"status": "pending",
"text": "l"
},
{
"id": 18,
"status": "pending",
"text": "m"
},
{
"id": 19,
"status": "pending",
"text": "n"
},
{
"id": 20,
"status": "pending",
"text": "o"
},
{
"id": 21,
"status": "pending",
"text": "p"
},
{
"id": 22,
"status": "pending",
"text": "q"
},
{
"id": 23,
"status": "pending",
"text": "r"
},
{
"id": 24,
"status": "pending",
"text": "s"
},
{
"id": 25,
"status": "pending",
"text": "t"
}
]
},
{
"name": "liste rangée illisible",
"put": "{\"pas\":\"une liste\"}",
"args": {
"action": "list"
},
"out": "[aucun critère]",
"stored": {
"pas": "une liste"
}
}
]
+50
View File
@@ -67,3 +67,53 @@ async fn le_reste_va_au_go() {
let args = a(json!({"pattern":"*"}));
assert!(exec_local(&st, false, "glob", &args, "*").await.is_some());
}
/// Lot 38 : l'outil criteria du mode Code, rejoué contre le journal du Go
/// (`internal/loki/parity_criteria_test.go` → `parity_tools/criteria.json`) :
/// résultat de chaque appel, critères rangés après coup (scellés), et la
/// liste poussée à l'écran quand elle change.
#[tokio::test]
async fn criteria_comme_le_go() {
use loki_rs::chat::crittool::{CRIT_MAX_COUNT, exec};
let fx: Value =
serde_json::from_str(include_str!("parity_tools/criteria.json")).expect("journal");
let t = tempfile::tempdir().unwrap();
let (_f, go, _stop) = common::fakego::start(t.path().into()).await;
let backend = go.backend.lock().unwrap().unwrap();
let store = loki_rs::store::Store::new(backend, common::fakego::JETON.into());
assert_eq!(CRIT_MAX_COUNT, 20);
let conv = "c1";
for st in fx.as_array().unwrap() {
let name = st["name"].as_str().unwrap();
if let Some(put) = st["put"].as_str() {
store
.put_seal("chat", &format!("crit:{conv}"), put.as_bytes().to_vec())
.await
.unwrap();
}
let args = st["args"].as_object().cloned().unwrap_or_default();
let verifier = st["verifier"].as_bool() == Some(true);
let before = store.get_open("chat", &format!("crit:{conv}")).await.unwrap();
let out = exec(&store, conv, &args, verifier).await;
assert_eq!(out.result, st["out"].as_str().unwrap(), "{name}");
let raw = store.get_open("chat", &format!("crit:{conv}")).await.unwrap();
let stored = raw
.as_deref()
.filter(|b| !b.is_empty())
.map(|b| serde_json::from_slice::<Value>(b).unwrap())
.unwrap_or(Value::Null);
assert_eq!(stored, st["stored"], "{name}");
// Scellés comme le contenu des discussions.
if let Some(sealed) = go.get("chat", &format!("crit:{conv}")) {
assert!(sealed.starts_with("SCELLE:"), "{name} : {sealed}");
}
// L'écran reçoit la liste quand elle change (vide : effacée).
match &out.notify {
Some(list) => {
let want = if stored.is_null() { json!([]) } else { stored.clone() };
assert_eq!(json!(list), want, "{name}");
}
None => assert_eq!(raw, before, "{name} : rien ne change sans notification"),
}
}
}