mirror of
https://github.com/R0m1k3/Priceflow.git
synced 2026-10-24 15:48:11 +02:00
Fix: Deep fix for Action.com availability false positives. Advanced title normalization and clarified unavailability detection logic. Optimized ActionParser.
This commit is contained in:
1 parent
8329eb28a3
commit
4a686e1b86
3 files changed
+63
-25
No files matched your search
@@ -1,9 +1,11 @@
|
|||||||
from bs4 import BeautifulSoup
|
from bs4 import BeautifulSoup
|
||||||
from app.services.parsers.base_parser import BaseParser, ProductResult
|
from app.services.parsers.base_parser import BaseParser, ProductResult
|
||||||
import logging
|
import logging
|
||||||
|
import re
|
||||||
|
|
||||||
logger = logging.getLogger(__name__)
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
|
||||||
class ActionParser(BaseParser):
|
class ActionParser(BaseParser):
|
||||||
def __init__(self):
|
def __init__(self):
|
||||||
super().__init__("action.com", "https://www.action.com")
|
super().__init__("action.com", "https://www.action.com")
|
||||||
@@ -21,7 +23,7 @@ class ActionParser(BaseParser):
|
|||||||
|
|
||||||
for link in links:
|
for link in links:
|
||||||
try:
|
try:
|
||||||
href = link.get('href')
|
href = link.get("href")
|
||||||
if not href or href in seen_urls:
|
if not href or href in seen_urls:
|
||||||
continue
|
continue
|
||||||
seen_urls.add(href)
|
seen_urls.add(href)
|
||||||
@@ -34,7 +36,12 @@ class ActionParser(BaseParser):
|
|||||||
if title_el:
|
if title_el:
|
||||||
title = title_el.get_text(strip=True)
|
title = title_el.get_text(strip=True)
|
||||||
else:
|
else:
|
||||||
title = link.get_text(strip=True)
|
# Fallback to specific spans or remove price info from text
|
||||||
|
# Often Action cards have a .title span
|
||||||
|
title = link.get_text(" ", strip=True)
|
||||||
|
# Remove price-like patterns from title if we had to get whole link text
|
||||||
|
title = re.sub(r"\d+,\d+\s*€.*$", "", title)
|
||||||
|
title = re.sub(r"\d+\s*€.*$", "", title)
|
||||||
|
|
||||||
if not title:
|
if not title:
|
||||||
continue
|
continue
|
||||||
@@ -46,16 +53,18 @@ class ActionParser(BaseParser):
|
|||||||
if price_el:
|
if price_el:
|
||||||
price = self.parse_price_text(price_el.get_text())
|
price = self.parse_price_text(price_el.get_text())
|
||||||
|
|
||||||
results.append(ProductResult(
|
results.append(
|
||||||
title=title,
|
ProductResult(
|
||||||
url=url,
|
title=title,
|
||||||
source="Action",
|
url=url,
|
||||||
price=price,
|
source="Action",
|
||||||
currency="EUR",
|
price=price,
|
||||||
in_stock=True,
|
currency="EUR",
|
||||||
image_url=img_url,
|
in_stock=True,
|
||||||
snippet=f"Product from Action"
|
image_url=img_url,
|
||||||
))
|
snippet=f"Product from Action",
|
||||||
|
)
|
||||||
|
)
|
||||||
|
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
logger.error(f"Error parsing Action product: {e}")
|
logger.error(f"Error parsing Action product: {e}")
|
||||||
|
|||||||
@@ -54,10 +54,17 @@ def _normalize_title(title: str) -> str:
|
|||||||
title = re.sub(r"([a-zA-Z])(\d)", r"\1 \2", title)
|
title = re.sub(r"([a-zA-Z])(\d)", r"\1 \2", title)
|
||||||
title = re.sub(r"(\d)([a-zA-Z])", r"\1 \2", title)
|
title = re.sub(r"(\d)([a-zA-Z])", r"\1 \2", title)
|
||||||
|
|
||||||
# Remove extra spaces and punctuation that might differ between sites
|
# Remove non-word characters (punctuation) early to simplify regex
|
||||||
title = re.sub(r"[^\w\s]", " ", title)
|
title = re.sub(r"[^\w\s]", " ", title)
|
||||||
title = " ".join(title.split())
|
title = " ".join(title.split())
|
||||||
|
|
||||||
|
# Remove technical metadata at the end (Action specific noise)
|
||||||
|
# Match various patterns like "0 09 pce 342" or "100 pièces" etc.
|
||||||
|
title = re.sub(r"\s+\d+\s+\d+\s+pce.*$", "", title)
|
||||||
|
title = re.sub(r"\s+\d+\s+pièces.*$", "", title)
|
||||||
|
title = re.sub(r"\s+\d+\s+€.*$", "", title)
|
||||||
|
title = re.sub(r"\s+\d+\s+\d+\s+€.*$", "", title)
|
||||||
|
|
||||||
return title.strip()
|
return title.strip()
|
||||||
|
|
||||||
|
|
||||||
@@ -363,6 +370,28 @@ async def process_item_check(item_id: int):
|
|||||||
f"Stored: '{item_data['name']}', Page title: '{page_title}'"
|
f"Stored: '{item_data['name']}', Page title: '{page_title}'"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
# For Action.com, if we haven't confirmed unavailability above,
|
||||||
|
# don't mark as unavailable yet, just mark as potential replacement error
|
||||||
|
# unless the title is almost completely different
|
||||||
|
if is_action:
|
||||||
|
# Check if at least some significant words match
|
||||||
|
norm_stored = _normalize_title(item_data["name"])
|
||||||
|
norm_page = _normalize_title(page_title)
|
||||||
|
stored_words = set(norm_stored.split())
|
||||||
|
page_words = set(norm_page.split())
|
||||||
|
intersection = stored_words & page_words
|
||||||
|
if len(intersection) >= 2 or (len(stored_words) <= 3 and len(intersection) >= 1):
|
||||||
|
logger.warning(
|
||||||
|
f"Borderline title match for Action.com item {item_id}. Keeping as available but marking error."
|
||||||
|
)
|
||||||
|
await loop.run_in_executor(
|
||||||
|
None,
|
||||||
|
_update_db_error,
|
||||||
|
item_id,
|
||||||
|
f"Titre différent mais produit probablement correct : {page_title}",
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
await loop.run_in_executor(
|
await loop.run_in_executor(
|
||||||
None,
|
None,
|
||||||
_update_db_product_unavailable,
|
_update_db_product_unavailable,
|
||||||
|
|||||||
@@ -1,21 +1,21 @@
|
|||||||
# Nettoyage et Commit du Projet
|
# Deep Debugging Action.com Availability
|
||||||
|
|
||||||
## Contexte
|
## Context
|
||||||
|
|
||||||
Après avoir corrigé les problèmes de disponibilité d'Action.com et Amazon, il est nécessaire de nettoyer le répertoire racine des scripts de diagnostic et fichiers temporaires avant de committer les changements.
|
Some products on Action.com are still marked as unavailable even after the first round of fixes.
|
||||||
|
|
||||||
## Focus Actuel
|
## Current Focus
|
||||||
|
|
||||||
Identification et suppression des fichiers inutiles, suivi du commit et push.
|
Identifying why specific Action.com products fail the availability check.
|
||||||
|
|
||||||
## Master Plan
|
## Master Plan
|
||||||
|
|
||||||
- [ ] Identifier les fichiers non essentiels à l'application
|
- [ ] List currently unavailable Action.com items from the database (if possible) or logs
|
||||||
- [ ] Supprimer les fichiers de diagnostic et scripts temporaires
|
- [ ] Reproduce the check for a specific problematic item
|
||||||
- [ ] Vérifier que l'application fonctionne toujours (build/syntaxe)
|
- [ ] Analyze the HTML and Title for these items
|
||||||
- [ ] Committer les changements vers le dépôt Git
|
- [ ] Refine the matching logic or the unavailability detection
|
||||||
- [ ] Pusher les changements
|
- [ ] Verify fix with multiple Action.com items
|
||||||
|
|
||||||
## Log de Progression
|
## Progress Log
|
||||||
|
|
||||||
- [ ] Planification du nettoyage commencée.
|
- [/] Task started.
|
||||||
Reference in new issue
Block a user