From 6531e3318dfb8fc44855bd3620b46800e53d875d Mon Sep 17 00:00:00 2001
From: Reviflow Bot <bot@reviflow.ai>
Date: Thu, 5 Feb 2026 22:00:52 +0100
Subject: [PATCH] feat(quiz): implement two-step answer validation logic

---
 frontend/src/features/quiz/QuestionCard.tsx | 106 ++++++++++++--------
 frontend/src/features/quiz/QuizPage.tsx     |  34 +++++--
 2 files changed, 93 insertions(+), 47 deletions(-)

diff --git a/frontend/src/features/quiz/QuestionCard.tsx b/frontend/src/features/quiz/QuestionCard.tsx
index 117079f..3f7213e 100644
--- a/frontend/src/features/quiz/QuestionCard.tsx
+++ b/frontend/src/features/quiz/QuestionCard.tsx
@@ -10,6 +10,7 @@ interface QuestionCardProps {
     currentStep: number;
     totalSteps: number;
     explanation?: string;
+    isValidated: boolean; // New prop
 }
 
 export function QuestionCard({
@@ -20,24 +21,22 @@ export function QuestionCard({
     onSelectOption,
     currentStep,
     totalSteps,
-    explanation
+    explanation,
+    isValidated // Destructure new prop
 }: QuestionCardProps) {
     const [animation, setAnimation] = useState<'pop' | 'shake' | null>(null);
 
     useEffect(() => {
-        if (selectedOption !== null) {
+        if (isValidated && selectedOption !== null) {
             if (selectedOption === correctAnswer) {
                 setAnimation('pop');
             } else {
                 setAnimation('shake');
             }
-            // Removed auto-hide timer for animation to keep state clear, 
-            // but we might want to keep the effect. 
-            // The user wants "time to read", so we shouldn't auto-advance too fast in parent.
             const timer = setTimeout(() => setAnimation(null), 500);
             return () => clearTimeout(timer);
         }
-    }, [selectedOption, correctAnswer]);
+    }, [isValidated, selectedOption, correctAnswer]); // Trigger on validation
 
     const isCorrect = selectedOption === correctAnswer;
 
@@ -60,42 +59,69 @@ export function QuestionCard({
             <h2 className="text-3xl font-black text-slate-900 dark:text-white mb-10 leading-tight tracking-tight">{question}</h2>
 
             <div className="grid grid-cols-1 gap-4 mb-4">
-                {options.map((option, index) => (
-                    <button
-                        key={index}
-                        disabled={selectedOption !== null}
-                        onClick={() => onSelectOption(index)}
-                        className={`w-full text-left p-5 border-2 rounded-xl transition-all duration-200 group relative ${selectedOption === null
-                            ? 'border-slate-100 dark:border-slate-700 hover:border-soft-indigo dark:hover:border-indigo-500 hover:bg-indigo-50/30 dark:hover:bg-indigo-900/20'
-                            : selectedOption === index
-                                ? index === correctAnswer
-                                    ? 'border-green-500 bg-green-50 dark:bg-green-900/20 text-green-700 dark:text-green-400'
-                                    : 'border-orange-400 bg-orange-50 dark:bg-orange-900/20 text-orange-700 dark:text-orange-400'
-                                : index === correctAnswer
-                                    ? 'border-green-500 bg-green-50/50 dark:bg-green-900/10'
-                                    : 'border-slate-100 dark:border-slate-700 opacity-50'
-                            }`}
-                    >
-                        <div className="flex items-center">
-                            <span className={`flex-shrink-0 h-8 w-8 flex items-center justify-center rounded-full border-2 text-sm font-bold transition-colors ${selectedOption === null
-                                ? 'border-slate-200 dark:border-slate-600 text-slate-400 dark:text-slate-500 group-hover:border-soft-indigo dark:group-hover:border-indigo-400 group-hover:text-soft-indigo dark:group-hover:text-indigo-400'
-                                : selectedOption === index
-                                    ? index === correctAnswer
-                                        ? 'border-green-500 bg-green-500 text-white'
-                                        : 'border-orange-400 bg-orange-400 text-white'
-                                    : index === correctAnswer
-                                        ? 'border-green-500 text-green-500'
-                                        : 'border-slate-200 dark:border-slate-600 text-slate-300 dark:text-slate-600'
-                                }`}>
-                                {String.fromCharCode(65 + index)}
-                            </span>
-                            <span className="ml-4 text-lg font-medium text-slate-700 dark:text-slate-200">{option}</span>
-                        </div>
-                    </button>
-                ))}
+                {options.map((option, index) => {
+                    // Logic for visual states
+                    let borderClass = 'border-slate-100 dark:border-slate-700';
+                    let bgClass = 'hover:bg-indigo-50/30 dark:hover:bg-indigo-900/20';
+                    let textClass = '';
+                    let opacityClass = '';
+
+                    if (selectedOption === index) {
+                        if (!isValidated) {
+                            // Selected but not validated: Blue/Neutral
+                            borderClass = 'border-indigo-500 dark:border-indigo-400';
+                            bgClass = 'bg-indigo-50 dark:bg-indigo-900/20';
+                            textClass = 'text-indigo-700 dark:text-indigo-300';
+                        } else {
+                            // Validated: Green or Red
+                            if (index === correctAnswer) {
+                                borderClass = 'border-green-500';
+                                bgClass = 'bg-green-50 dark:bg-green-900/20';
+                                textClass = 'text-green-700 dark:text-green-400';
+                            } else {
+                                borderClass = 'border-orange-400';
+                                bgClass = 'bg-orange-50 dark:bg-orange-900/20';
+                                textClass = 'text-orange-700 dark:text-orange-400';
+                            }
+                        }
+                    } else if (isValidated && index === correctAnswer) {
+                        // Show correct answer if user got it wrong
+                        borderClass = 'border-green-500';
+                        bgClass = 'bg-green-50/50 dark:bg-green-900/10';
+                        textClass = 'text-green-700 dark:text-green-400';
+                    } else if (isValidated) {
+                        // Fade out other options when validated
+                        opacityClass = 'opacity-50';
+                    }
+
+                    return (
+                        <button
+                            key={index}
+                            disabled={isValidated} // Disable buttons after validation
+                            onClick={() => onSelectOption(index)}
+                            className={`w-full text-left p-5 border-2 rounded-xl transition-all duration-200 group relative ${borderClass} ${bgClass} ${textClass} ${opacityClass}`}
+                        >
+                            <div className="flex items-center">
+                                <span className={`flex-shrink-0 h-8 w-8 flex items-center justify-center rounded-full border-2 text-sm font-bold transition-colors ${selectedOption === index
+                                    ? isValidated
+                                        ? index === correctAnswer
+                                            ? 'border-green-500 bg-green-500 text-white'
+                                            : 'border-orange-400 bg-orange-400 text-white'
+                                        : 'border-indigo-500 bg-indigo-500 text-white' // Selected pre-validation
+                                    : isValidated && index === correctAnswer
+                                        ? 'border-green-500 text-green-500' // Show correct
+                                        : 'border-slate-200 dark:border-slate-600 text-slate-400 dark:text-slate-500 group-hover:border-soft-indigo dark:group-hover:border-indigo-400 group-hover:text-soft-indigo dark:group-hover:text-indigo-400'
+                                    }`}>
+                                    {String.fromCharCode(65 + index)}
+                                </span>
+                                <span className={`ml-4 text-lg font-medium ${textClass || 'text-slate-700 dark:text-slate-200'}`}>{option}</span>
+                            </div>
+                        </button>
+                    );
+                })}
             </div>
 
-            {selectedOption !== null && (
+            {isValidated && selectedOption !== null && (
                 <div className={`mt-6 p-6 rounded-2xl animate-in fade-in slide-in-from-top-2 duration-300 ${isCorrect ? 'bg-green-50 dark:bg-green-900/20 border border-green-100 dark:border-green-900/30' : 'bg-orange-50 dark:bg-orange-900/20 border border-orange-100 dark:border-orange-900/30'}`}>
                     <div className="flex items-start gap-4">
                         <div className={`text-2xl ${isCorrect ? 'grayscale-0' : 'grayscale-0'}`}>
diff --git a/frontend/src/features/quiz/QuizPage.tsx b/frontend/src/features/quiz/QuizPage.tsx
index b3d9b2d..e11c586 100644
--- a/frontend/src/features/quiz/QuizPage.tsx
+++ b/frontend/src/features/quiz/QuizPage.tsx
@@ -37,6 +37,7 @@ export function QuizPage() {
     const [quizData, setQuizData] = useState<QuizResponse | null>(null);
     const [currentQuestionIndex, setCurrentQuestionIndex] = useState(0);
     const [selectedOption, setSelectedOption] = useState<number | null>(null);
+    const [isValidated, setIsValidated] = useState(false); // New state for validation
     const [score, setScore] = useState(0);
     const [answers, setAnswers] = useState<any[]>([]); // Track details
     const [isFinished, setIsFinished] = useState(false);
@@ -129,19 +130,26 @@ export function QuizPage() {
         if (currentQuestionIndex < (quizData?.questions.length || 0) - 1) {
             setCurrentQuestionIndex(prev => prev + 1);
             setSelectedOption(null);
+            setIsValidated(false); // Reset validation for next question
         } else {
             setIsFinished(true);
         }
     };
 
+    // Change: Selected option just updates state, doesn't lock yet
     const handleOptionSelect = (index: number) => {
-        if (selectedOption !== null) return; // Prevent changing answer
+        if (isValidated) return; // Prevent changing answer if already validated
         setSelectedOption(index);
+    };
 
-        if (!quizData) return;
+    // New: Validate the answer
+    const handleValidate = () => {
+        if (selectedOption === null || isValidated || !quizData) return;
+
+        setIsValidated(true);
 
         const currentQ = quizData.questions[currentQuestionIndex];
-        const isCorrect = index === currentQ.correct_answer;
+        const isCorrect = selectedOption === currentQ.correct_answer;
 
         if (isCorrect) {
             setScore(prev => prev + 1);
@@ -150,7 +158,7 @@ export function QuizPage() {
         // Record answer details
         setAnswers(prev => [...prev, {
             question: currentQ.question,
-            user_answer: currentQ.options[index],
+            user_answer: currentQ.options[selectedOption],
             correct_answer: currentQ.options[currentQ.correct_answer],
             is_correct: isCorrect,
             original_content: null
@@ -311,13 +319,25 @@ export function QuizPage() {
                             currentStep={currentQuestionIndex + 1}
                             totalSteps={quizData.questions.length}
                             explanation={quizData.questions[currentQuestionIndex].explanation}
+                            isValidated={isValidated} // Pass validation state
                         />
 
-                        {/* NEXT BUTTON */}
-                        {selectedOption !== null && (
+                        {/* VALIDATE BUTTON */}
+                        {selectedOption !== null && !isValidated && (
+                            <button
+                                onClick={handleValidate}
+                                className="mt-8 bg-indigo-600 text-white font-black text-lg py-4 px-12 rounded-2xl shadow-xl shadow-indigo-200 dark:shadow-none hover:bg-indigo-700 hover:scale-105 hover:shadow-2xl transition-all duration-300 animate-in fade-in slide-in-from-bottom-4 flex items-center gap-3 group"
+                            >
+                                <span>Valider la réponse</span>
+                                <span className="text-2xl group-hover:scale-110 transition-transform">✓</span>
+                            </button>
+                        )}
+
+                        {/* NEXT BUTTON (Only show after validation) */}
+                        {isValidated && (
                             <button
                                 onClick={handleNext}
-                                className="mt-8 bg-indigo-600 text-white font-black text-lg py-4 px-12 rounded-2xl shadow-xl shadow-indigo-200 hover:bg-indigo-700 hover:scale-105 hover:shadow-2xl transition-all duration-300 animate-in fade-in slide-in-from-bottom-4 flex items-center gap-3 group"
+                                className="mt-8 bg-indigo-600 text-white font-black text-lg py-4 px-12 rounded-2xl shadow-xl shadow-indigo-200 dark:shadow-none hover:bg-indigo-700 hover:scale-105 hover:shadow-2xl transition-all duration-300 animate-in fade-in slide-in-from-bottom-4 flex items-center gap-3 group"
                             >
                                 <span>Question Suivante</span>
                                 <span className="text-2xl group-hover:translate-x-1 transition-transform">➜</span>