Fix four defects the screenshots and tests exposed
Verifying the rendered pages rather than the build turned up real bugs: - The WP-00 health page still sat at src/app/page.tsx and silently won the route over the new Aperçu screen, so the home page was a database status readout. Moved to /api/sante, where a probe belongs, and wired into the compose healthcheck. - The unassigned row showed a +14 h delta against a contract of zero, reading as an overshoot when it is simply the volume left to staff. It now shows what there is to fill. - Two sidebar entries lit at once: an anchor link matched its own page, and /equipe matched an employee record. Highlighting now resolves to the most specific match, and a test asserts exactly one entry lights per screen. - Section tabs with no built screen pointed at the home page, which reads as a broken tab. They now lead to their first entry's placeholder. Also gives truncated compliance alerts a title attribute, so a narrow cell no longer says there is a problem without saying which. Playwright can reuse a preinstalled browser through PLAYWRIGHT_CHROMIUM_PATH when its revision differs from the bundled one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cr9dkEHwbDgkWPnyGj1Rjv
This commit is contained in:
11 files changed
+260
-47
No files matched your search
@@ -11,7 +11,9 @@ import { cx } from '@/lib/cx';
|
||||
import {
|
||||
isActive,
|
||||
NAVIGATION,
|
||||
placeholderHref,
|
||||
sectionForPath,
|
||||
sectionHref,
|
||||
type NavItem,
|
||||
} from '@/components/shell/navigation';
|
||||
|
||||
@@ -36,12 +38,11 @@ export function AppShell({ children }: AppShellProps) {
|
||||
|
||||
<nav aria-label="Sections" className="flex h-full gap-0.5">
|
||||
{NAVIGATION.map((entry) => {
|
||||
const target = entry.items.find((item) => item.href);
|
||||
const current = entry.id === section.id;
|
||||
return (
|
||||
<Link
|
||||
key={entry.id}
|
||||
href={target?.href ?? '/'}
|
||||
href={sectionHref(entry)}
|
||||
aria-current={current ? 'page' : undefined}
|
||||
className={cx(
|
||||
'flex h-full items-center border-b-2 px-3.5 text-sm font-medium whitespace-nowrap',
|
||||
@@ -118,10 +119,7 @@ function SidebarLink({ item, pathname }: { item: NavItem; pathname: string }) {
|
||||
|
||||
if (!item.href) {
|
||||
return (
|
||||
<Link
|
||||
href={`/bientot?ecran=${encodeURIComponent(item.label)}`}
|
||||
className={cx(className, 'text-ink-3')}
|
||||
>
|
||||
<Link href={placeholderHref(item.label)} className={cx(className, 'text-ink-3')}>
|
||||
{content}
|
||||
</Link>
|
||||
);
|
||||
|
||||
@@ -85,14 +85,57 @@ export const NAVIGATION: NavSection[] = [
|
||||
|
||||
/** Section contenant la route donnée, ou la première par défaut. */
|
||||
export function sectionForPath(pathname: string): NavSection {
|
||||
const match = NAVIGATION.find((section) =>
|
||||
section.items.some((item) => item.href && isActive(item.href, pathname)),
|
||||
);
|
||||
const active = activeItem(pathname);
|
||||
const match = active
|
||||
? NAVIGATION.find((section) =>
|
||||
section.items.some((item) => item.id === active.id),
|
||||
)
|
||||
: undefined;
|
||||
return match ?? (NAVIGATION[0] as NavSection);
|
||||
}
|
||||
|
||||
/** Chemin vers l'écran d'attente d'une entrée non encore construite. */
|
||||
export function placeholderHref(label: string): string {
|
||||
return `/bientot?ecran=${encodeURIComponent(label)}`;
|
||||
}
|
||||
|
||||
/**
|
||||
* Destination d'un onglet de section.
|
||||
*
|
||||
* Une section dont aucun écran n'est construit ne doit pas renvoyer à
|
||||
* l'accueil : le clic donnerait l'impression que l'onglet est cassé. Elle mène
|
||||
* à l'écran d'attente de sa première entrée, qui dit ce qui viendra là.
|
||||
*/
|
||||
export function sectionHref(section: NavSection): string {
|
||||
const built = section.items.find((item) => item.href);
|
||||
if (built?.href) return built.href;
|
||||
const first = section.items[0];
|
||||
return first ? placeholderHref(first.label) : '/';
|
||||
}
|
||||
|
||||
export function matches(href: string, pathname: string): boolean {
|
||||
// Un lien d'ancre pointe à l'intérieur d'une page déjà représentée par une
|
||||
// autre entrée : il ne concourt pas.
|
||||
if (href.includes('#')) return false;
|
||||
|
||||
if (href === '/') return pathname === '/';
|
||||
return pathname === href || pathname.startsWith(`${href}/`);
|
||||
}
|
||||
|
||||
/**
|
||||
* Entrée à mettre en évidence pour une route donnée.
|
||||
*
|
||||
* `/equipe` et `/equipe/camille-ferrand` correspondent tous deux quand on est
|
||||
* sur une fiche. On retient la **plus spécifique** : deux entrées allumées à la
|
||||
* fois, et le repère de position ne repère plus rien.
|
||||
*/
|
||||
export function activeItem(pathname: string): NavItem | undefined {
|
||||
return NAVIGATION.flatMap((section) => section.items)
|
||||
.filter((item) => item.href && matches(item.href, pathname))
|
||||
.sort((a, b) => (b.href as string).length - (a.href as string).length)[0];
|
||||
}
|
||||
|
||||
export function isActive(href: string, pathname: string): boolean {
|
||||
const base = href.split('#')[0] ?? href;
|
||||
if (base === '/') return pathname === '/';
|
||||
return pathname === base || pathname.startsWith(`${base}/`);
|
||||
const active = activeItem(pathname);
|
||||
return active?.href === href;
|
||||
}
|
||||
Reference in new issue
Block a user