mirror of
https://github.com/R0m1k3/xtremflow.git
synced 2026-10-21 14:08:04 +02:00
feat: security hardening, streaming overhaul, design polish, tests
Security: - Replace unsalted SHA-256 password hashing with bcrypt (lazy rehash on login) - Add authenticated /api/xtream-api gateway: Xtream credentials are injected server-side and never sent to the frontend; /api/playlists no longer returns passwords - Redact credentials from all logs (login body, proxy/FFmpeg/scheduler URLs) - Add auth to recordings, EPG, season-passes and streaming routes (HttpOnly session cookie for hls.js; loopback bypass for local FFmpeg) - Lock player postMessage to same-origin in both directions - Vendor and pin hls.js 1.6.7 / mpegts.js 1.7.3 (drop CDN @latest) - Fix rate limiter (client IP was never resolved), add login rate limit, restrict CORS, add CSP Report-Only, block private-IP SSRF targets, fix path traversal in recording log retrieval, chmod 777 -> 770 - Remove dead HiveService (seeded admin/admin into IndexedDB with SHA-256) - Fix authMiddleware not populating 'user' context (getPlaylist ignored the logged-in user; admin purge always returned 403) Streaming: - New FfmpegSessionManager: process registry, idle reaper (4 min live / 15 min VOD), orphan cleanup at startup, clean SIGTERM shutdown, fast-fail with stderr instead of 30 s timeout - Quality selection (source/high/medium/low) for live and VOD; source mode streams with -c:v copy (zero transcoding); selector wired into the player - Concurrent recordings (MAX_CONCURRENT_RECORDINGS, default 2); conflicts retry on the next tick instead of silently failing - Lower live latency (HLS window 20 -> 10 segments, liveSync 10 -> 3) - Fix recording log lookup (.mp4 vs .mkv mismatch) Design: - Replace hardcoded colors with AppColors tokens (12 files) - web/theme.css syncs HTML players with the Flutter palette - DPAD/keyboard navigation (arrow-key focus, player shortcuts) - Tooltips on player icon buttons, Semantics on content cards - Remove 7 dead widgets broken since the Stitch merge Quality: - bin/test/: 21 unit tests (bcrypt, redaction, traversal, SSRF, recording conflicts) plus a quality-selector widget test - GitHub Actions CI (analyze + test + build web) - Archive stale status docs into docs/archive/ Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
cb5eca7547
commit
60d3f42901
107 files changed
+4525
-3815
No files matched your search
@@ -1,3 +1,4 @@
|
||||
import 'dart:io';
|
||||
import 'package:shelf/shelf.dart';
|
||||
import '../database/database.dart';
|
||||
|
||||
@@ -16,16 +17,20 @@ Middleware authMiddleware(AppDatabase db) {
|
||||
return Response(401, body: 'Unauthorized');
|
||||
}
|
||||
|
||||
// Verify session
|
||||
// Verify session (findSessionByToken enforces expires_at)
|
||||
final session = db.findSessionByToken(token);
|
||||
if (session == null) {
|
||||
return Response(401, body: 'Invalid or expired session');
|
||||
}
|
||||
|
||||
// Add userId to context
|
||||
// Add user info to context. Both keys are populated because handlers
|
||||
// are inconsistent: playlists_handler reads 'userId', while
|
||||
// getPlaylist/admin routes read 'user'.
|
||||
final user = db.findUserById(session.userId);
|
||||
final updatedRequest = request.change(context: {
|
||||
...request.context,
|
||||
'userId': session.userId,
|
||||
if (user != null) 'user': user,
|
||||
},);
|
||||
|
||||
return handler(updatedRequest);
|
||||
@@ -33,6 +38,33 @@ Middleware authMiddleware(AppDatabase db) {
|
||||
};
|
||||
}
|
||||
|
||||
/// Auth middleware for streaming routes (HLS playlists/segments).
|
||||
///
|
||||
/// hls.js/mpegts.js inside the player iframe cannot send Authorization
|
||||
/// headers, so these routes accept the HttpOnly session cookie instead.
|
||||
/// Loopback requests without X-Forwarded-For are allowed through because
|
||||
/// the recording scheduler's local FFmpeg fetches
|
||||
/// `http://localhost:8089/api/live/<id>.ts` without credentials.
|
||||
Middleware streamAuthMiddleware(AppDatabase db) {
|
||||
return (Handler handler) {
|
||||
return (Request request) async {
|
||||
final connectionInfo =
|
||||
request.context['shelf.io.connection_info'] as HttpConnectionInfo?;
|
||||
final isLoopback = connectionInfo?.remoteAddress.isLoopback ?? false;
|
||||
final viaProxy = request.headers.containsKey('x-forwarded-for');
|
||||
if (isLoopback && !viaProxy) {
|
||||
return handler(request);
|
||||
}
|
||||
|
||||
final token = _extractToken(request);
|
||||
if (token == null || db.findSessionByToken(token) == null) {
|
||||
return Response(401, body: 'Unauthorized');
|
||||
}
|
||||
return handler(request);
|
||||
};
|
||||
};
|
||||
}
|
||||
|
||||
/// Extract token from Authorization header or cookie
|
||||
String? _extractToken(Request request) {
|
||||
// Try Authorization header first
|
||||
|
||||
Reference in new issue
Block a user