mirror of
https://github.com/R0m1k3/xtremflow.git
synced 2026-10-12 01:36:20 +02:00
Proxy /api/xtream :
- Authentification de session rétablie (Authorization ou cookie HttpOnly
session — les requêtes navigateur même-origine le portent) ; le proxy
était volontairement ouvert, offrant un rebond SSRF non authentifié
- Redirections suivies manuellement avec revalidation à chaque saut
(hôte privé interdit + allowlist de domaine) : avec followRedirects,
seule l'URL initiale était validée, une 302 amont suffisait pour
atteindre un hôte interne
- Erreurs proxy sans détail d'exception (ClientException porte l'URL
amont, credentials Xtream inclus), logs redactés
Logs :
- redactedLogRequests remplace logRequests() de shelf : l'URI de
/api/xtream/<url> écrivait username/password Xtream en clair à chaque
requête, annulant l'effort de LogRedactor partout ailleurs
- Les 500 d'epg_api ne renvoient plus e.toString() au client (même
risque ClientException) ; détail redacté en log serveur
Middleware :
- X-Forwarded-For honoré uniquement depuis un proxy de confiance
(loopback + RFC1918 par défaut, surchargables via TRUSTED_PROXIES) :
un client direct forgeait l'en-tête et contournait le rate limit
global comme la limite de tentatives de login
- Honeypot comparé sur chemin exact/préfixe : l'ancien
contains(trap.replaceAll('/','')) bloquait toute URL contenant
console, env ou wpadmin, y compris des URLs proxifiées légitimes
Comptes :
- Mot de passe admin initial aléatoire (Random.secure, affiché une fois
au démarrage) ou ADMIN_INITIAL_PASSWORD ; fini le admin/admin persistant
- Longueur minimale de 8 caractères à la création et au changement
Divers :
- CleanupService ne cible plus Directory.systemTemp en récursif (il
supprimait les temporaires de la VM Dart et le parent des sessions HLS)
- web/xf-player-core.js : postMessage vers location.origin au lieu de
'*', et filtrage d'event.origin à la réception (le côté Flutter le
faisait déjà)
Validé : dart analyze (0 issue) et dart test (48/48) sur bin/.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015oEu9QayWsw7hCKhenxgVa
181 lines
5.9 KiB
Dart
181 lines
5.9 KiB
Dart
import 'dart:convert';
|
|
import 'package:shelf/shelf.dart';
|
|
import 'package:shelf_router/shelf_router.dart';
|
|
import '../database/database.dart';
|
|
|
|
class UsersHandler {
|
|
final AppDatabase db;
|
|
|
|
UsersHandler(this.db);
|
|
|
|
Router get router {
|
|
final router = Router();
|
|
router.get('/', _getAllUsers);
|
|
router.post('/', _createUser);
|
|
router.put('/<id>/password', _updatePassword);
|
|
router.put('/<id>', _updateUser);
|
|
router.delete('/<id>', _deleteUser);
|
|
return router;
|
|
}
|
|
|
|
/// Check if requester is admin
|
|
bool _isAdmin(Request request) {
|
|
final userId = request.context['userId'] as String?;
|
|
if (userId == null) return false;
|
|
final user = db.findUserById(userId);
|
|
return user?.isAdmin ?? false;
|
|
}
|
|
|
|
/// GET /api/users
|
|
Future<Response> _getAllUsers(Request request) async {
|
|
try {
|
|
if (!_isAdmin(request)) {
|
|
return Response.forbidden(jsonEncode({'success': false, 'error': 'Admin required'}));
|
|
}
|
|
|
|
final users = db.getAllUsers();
|
|
return Response.ok(jsonEncode({
|
|
'success': true,
|
|
'users': users.map((u) => u.toJson()).toList(),
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
} catch (e) {
|
|
return Response.internalServerError(
|
|
body: jsonEncode({'success': false, 'error': e.toString()}),
|
|
headers: {'Content-Type': 'application/json'},
|
|
);
|
|
}
|
|
}
|
|
|
|
/// POST /api/users
|
|
Future<Response> _createUser(Request request) async {
|
|
try {
|
|
if (!_isAdmin(request)) {
|
|
return Response.forbidden(jsonEncode({'success': false, 'error': 'Admin required'}));
|
|
}
|
|
|
|
final payload = jsonDecode(await request.readAsString()) as Map<String, dynamic>;
|
|
final username = payload['username'] as String?;
|
|
final password = payload['password'] as String?;
|
|
final isAdmin = payload['isAdmin'] as bool? ?? false;
|
|
|
|
if (username == null || password == null) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Missing required fields',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
if (password.length < 8) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Le mot de passe doit faire au moins 8 caractères',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
if (db.findUserByUsername(username) != null) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Username already exists',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
final user = db.createUser(username, password, isAdmin: isAdmin);
|
|
return Response.ok(jsonEncode({
|
|
'success': true,
|
|
'user': user.toJson(),
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
|
|
} catch (e) {
|
|
return Response.internalServerError(
|
|
body: jsonEncode({'success': false, 'error': e.toString()}),
|
|
headers: {'Content-Type': 'application/json'},
|
|
);
|
|
}
|
|
}
|
|
|
|
/// PUT /api/users/:id/password
|
|
Future<Response> _updatePassword(Request request, String id) async {
|
|
try {
|
|
if (!_isAdmin(request)) {
|
|
return Response.forbidden(jsonEncode({'success': false, 'error': 'Admin required'}));
|
|
}
|
|
|
|
final payload = jsonDecode(await request.readAsString()) as Map<String, dynamic>;
|
|
final password = payload['password'] as String?;
|
|
|
|
if (password == null) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Missing password',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
if (password.length < 8) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Le mot de passe doit faire au moins 8 caractères',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
db.updateUserPassword(id, password);
|
|
return Response.ok(jsonEncode({'success': true}), headers: {'Content-Type': 'application/json'});
|
|
|
|
} catch (e) {
|
|
return Response.internalServerError(
|
|
body: jsonEncode({'success': false, 'error': e.toString()}),
|
|
headers: {'Content-Type': 'application/json'},
|
|
);
|
|
}
|
|
}
|
|
|
|
/// PUT /api/users/:id (Toggle Admin)
|
|
Future<Response> _updateUser(Request request, String id) async {
|
|
try {
|
|
if (!_isAdmin(request)) {
|
|
return Response.forbidden(jsonEncode({'success': false, 'error': 'Admin required'}));
|
|
}
|
|
|
|
final payload = jsonDecode(await request.readAsString()) as Map<String, dynamic>;
|
|
final isAdmin = payload['isAdmin'] as bool?;
|
|
|
|
if (isAdmin != null) {
|
|
db.updateUserAdminStatus(id, isAdmin);
|
|
}
|
|
|
|
return Response.ok(jsonEncode({'success': true}), headers: {'Content-Type': 'application/json'});
|
|
|
|
} catch (e) {
|
|
return Response.internalServerError(
|
|
body: jsonEncode({'success': false, 'error': e.toString()}),
|
|
headers: {'Content-Type': 'application/json'},
|
|
);
|
|
}
|
|
}
|
|
|
|
/// DELETE /api/users/:id
|
|
Future<Response> _deleteUser(Request request, String id) async {
|
|
try {
|
|
if (!_isAdmin(request)) {
|
|
return Response.forbidden(jsonEncode({'success': false, 'error': 'Admin required'}));
|
|
}
|
|
|
|
// Prevent deleting self
|
|
final currentUserId = request.context['userId'] as String;
|
|
if (currentUserId == id) {
|
|
return Response.badRequest(body: jsonEncode({
|
|
'success': false,
|
|
'error': 'Cannot delete yourself',
|
|
}), headers: {'Content-Type': 'application/json'},);
|
|
}
|
|
|
|
db.deleteUser(id);
|
|
return Response.ok(jsonEncode({'success': true}), headers: {'Content-Type': 'application/json'});
|
|
} catch (e) {
|
|
return Response.internalServerError(
|
|
body: jsonEncode({'success': false, 'error': e.toString()}),
|
|
headers: {'Content-Type': 'application/json'},
|
|
);
|
|
}
|
|
}
|
|
}
|